Skip to content

Fix CA's make test-in-docker command #8408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix CA's make test-in-docker command #8408

wants to merge 1 commit into from

Conversation

atwamahmoud
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Copies fix from /hack/for-go-proj.sh to /cluster-autoscaler/Makefile so that test-in-docker command doesn't fail.
This is a temporary workaround until all dependencies are updated/migrated.

Also see: #8121, #8110

Which issue(s) this PR fixes:

Fixes #8301

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area area/cluster-autoscaler labels Aug 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @atwamahmoud. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed do-not-merge/needs-area labels Aug 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atwamahmoud
Once this PR has been reviewed and has the lgtm label, please assign bigdarkclown for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2025
@atwamahmoud
Copy link
Contributor Author

/cc @x13n

@k8s-ci-robot k8s-ci-robot requested a review from x13n August 5, 2025 16:15
@jackfrancis
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2025
@elmiko
Copy link
Contributor

elmiko commented Sep 3, 2025

i tried this out locally, but i don't think it works with podman:

$ make test-in-docker
rm -f cluster-autoscaler-amd64
docker build --network=default -t autoscaling-builder ../builder
Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
STEP 1/9: FROM golang:1.24.0
✔ docker.io/library/golang:1.24.0
Trying to pull docker.io/library/golang:1.24.0...
Getting image source signatures
Copying blob 8985a99e1ce3 done   |
Copying blob 155ad54a8b28 done   |
Copying blob 1d281e50d3e4 done   |
Copying blob 9760da4e8f07 done   |
Copying blob 8031108f3cda done   |
Copying blob a2a60326dddc skipped: already exists
Copying blob 4f4fb700ef54 skipped: already exists
Copying config 245780beb8 done   |
Writing manifest to image destination
STEP 2/9: ENV GOPATH /gopath/
--> 99fce8b50e58
STEP 3/9: ENV PATH $GOPATH/bin:$PATH
--> b99d63f0bfca
STEP 4/9: ENV GO111MODULE auto
--> 6ef9ffdf9c6c
STEP 5/9: RUN apt-get update && apt-get --yes install libseccomp-dev
error running container: did not get container start message from parent: EOF
Error: building at STEP "RUN apt-get update && apt-get --yes install libseccomp-dev": setup network: cannot use networks as rootless
make: *** [Makefile:106: docker-builder] Error 125

@atwamahmoud
Copy link
Contributor Author

@elmiko I'm not that familiar with podman but I think this is not related to this specific change since it's complaining about rootless network issue while running apt-update -> setup network: cannot use networks as rootless

@elmiko
Copy link
Contributor

elmiko commented Sep 4, 2025

@atwamahmoud right, the dockerfile just isn't compatible with podman in default configuration. sorry, i don't have a true docker to test with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@vadasambar vadasambar Awaiting requested review from vadasambar

@x13n x13n Awaiting requested review from x13n

Assignees
No one assigned
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CA: make test-in-docker is broken
4 participants
@atwamahmoud @k8s-ci-robot @jackfrancis @elmiko